From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55343-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21013 invoked by alias); 22 Apr 2008 11:04:25 -0000
Received: (qmail 21002 invoked by uid 22791); 22 Apr 2008 11:04:25 -0000
X-Spam-Check-By: sourceware.org
Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 22 Apr 2008 11:04:07 +0000
Received: by calimero.vinschen.de (Postfix, from userid 500) 	id 1EED76D4312; Tue, 22 Apr 2008 13:04:05 +0200 (CEST)
Date: Tue, 22 Apr 2008 13:54:00 -0000
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Support for multiple calling conventions, patch 3/3: Use 	calling convention information to handle differnt ABIs on sh target
Message-ID: <20080422110403.GJ23852@calimero.vinschen.de>
Reply-To: gdb-patches@sourceware.org
Mail-Followup-To: gdb-patches@sourceware.org
References: <20080415115840.GA22994@calimero.vinschen.de> <20080417162802.GI17488@caradoc.them.org> <20080421153008.GV23852@calimero.vinschen.de> <uy7779epj.fsf@gnu.org> <20080421200051.GB23852@calimero.vinschen.de> <uve2aa7xy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <uve2aa7xy.fsf@gnu.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00467.txt.bz2

On Apr 22 06:23, Eli Zaretskii wrote:
> > Date: Mon, 21 Apr 2008 22:00:51 +0200
> > From: Corinna Vinschen <vinschen@redhat.com>
> > 
> > Thanks for the review.  Is that better?
> 
> Yes, thanks.  I have only two comment now:
> 
> > +@kindex set sh calling-convention @var{convention}
> 
> The @kindex entry should only mention the command, not its arguments.
> So please drop the "@var{convention}" part.
> 
> > "@cindex set SH Calling convention
> 
> And this index entry is now redundant: the @kindex one will serve the
> same purpose.
> 
> > +@kindex show sh calling-convention
> > +@cindex show SH Calling convention
> 
> Same here.

Thanks.  With these changes applied, I checked in the entire calling
convention patch now.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat