From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12711 invoked by alias); 21 Apr 2008 22:36:04 -0000 Received: (qmail 12700 invoked by uid 22791); 21 Apr 2008 22:36:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Apr 2008 22:35:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 26E9A983E4; Mon, 21 Apr 2008 22:35:42 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A1E1E9829E; Mon, 21 Apr 2008 22:35:41 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jo4bs-0000cf-OR; Mon, 21 Apr 2008 18:35:40 -0400 Date: Tue, 22 Apr 2008 03:24:00 -0000 From: Daniel Jacobowitz To: Craig Silverstein Cc: maxim@tensilica.com, gdb-patches@sourceware.org Subject: Re: GDB build is broken, when HAVE_ZLIB_H is not defined. Message-ID: <20080421223540.GA2350@caradoc.them.org> Mail-Followup-To: Craig Silverstein , maxim@tensilica.com, gdb-patches@sourceware.org References: <480D0394.8020404@hq.tensilica.com> <20080421220205.1C3313F2513@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080421220205.1C3313F2513@localhost> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00458.txt.bz2 On Mon, Apr 21, 2008 at 03:02:05PM -0700, Craig Silverstein wrote: > } in dwarf2read.c, should not it look like this : > > Never mind the approval; I ended up submitting this patch (as > suggested) under the Obvious Fix Rule. GDB folks, please let me know > if I did wrong. You did right. Thanks for the quick fix. -- Daniel Jacobowitz CodeSourcery