From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18865 invoked by alias); 21 Apr 2008 22:02:59 -0000 Received: (qmail 18843 invoked by uid 22791); 21 Apr 2008 22:02:52 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Apr 2008 22:02:34 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id m3LM2Db5023127; Mon, 21 Apr 2008 23:02:14 +0100 Received: from localhost (meta.corp.google.com [172.22.108.53]) by zps76.corp.google.com with ESMTP id m3LM25I0025782; Mon, 21 Apr 2008 15:02:06 -0700 Received: by localhost (Postfix, from userid 500) id 1C3313F2513; Mon, 21 Apr 2008 15:02:05 -0700 (PDT) To: maxim@tensilica.com CC: gdb-patches@sourceware.org In-reply-to: <480D0394.8020404@hq.tensilica.com> (message from Maxim Grigoriev on Mon, 21 Apr 2008 14:13:56 -0700) Subject: Re: GDB build is broken, when HAVE_ZLIB_H is not defined. References: <480D0394.8020404@hq.tensilica.com> Message-Id: <20080421220205.1C3313F2513@localhost> Date: Mon, 21 Apr 2008 22:38:00 -0000 From: csilvers@google.com (Craig Silverstein) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00456.txt.bz2 } in dwarf2read.c, should not it look like this : Never mind the approval; I ended up submitting this patch (as suggested) under the Obvious Fix Rule. GDB folks, please let me know if I did wrong. craig