From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27266 invoked by alias); 21 Apr 2008 20:01:19 -0000 Received: (qmail 27251 invoked by uid 22791); 21 Apr 2008 20:01:18 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 21 Apr 2008 20:00:54 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 667F56D4313; Mon, 21 Apr 2008 22:00:51 +0200 (CEST) Date: Mon, 21 Apr 2008 20:20:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] Support for multiple calling conventions, patch 3/3: Use calling convention information to handle differnt ABIs on sh target Message-ID: <20080421200051.GB23852@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20080415115840.GA22994@calimero.vinschen.de> <20080417162802.GI17488@caradoc.them.org> <20080421153008.GV23852@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00448.txt.bz2 On Apr 21 22:43, Eli Zaretskii wrote: > > Date: Mon, 21 Apr 2008 17:30:08 +0200 > > From: Corinna Vinschen > > > > Is the following documentation patch ok? > > Yes, with comments: > > > +@cindex Set SH Calling convention > > All index entries should start with a lower-case letter, for > consistency. > > > +In the @samp{gcc} setting, functions are called using the gcc calling > ^^ > "With" is better than "in" here. > > Also, we use @value{NGCC} instead of literal "gcc" (this doesn't apply > to @samp{gcc}, of course). > > > +convention. If the DWARF-2 information of the called function specifies > > +that the function is following the Renesas calling convention, the function > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > "the function follows the Renesas calling convention" > > > +is called using the renesas calling convention. If the calling convention > ^^^^^^^ > "renesas" or "Renesas"? we should be consistent. > > > +is set to @samp{renesas}, the Renesas calling convention is always used, > > +regardless of the Dwarf-2 information. This can be used to override the > > "DWARF-2" or "Dwarf-2"? > > > +@item show sh calling-convention > > +@cindex Show SH Calling convention > > Finally, please index each command (literally) with @kindex, as we do > for all other commands. Thanks for the review. Is that better? =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.483 diff -u -p -r1.483 gdb.texinfo --- gdb.texinfo 20 Apr 2008 09:06:43 -0000 1.483 +++ gdb.texinfo 21 Apr 2008 20:00:14 -0000 @@ -15649,6 +15649,26 @@ commands: @item regs @kindex regs@r{, Super-H} Show the values of all Super-H registers. + +@item set sh calling-convention @var{convention} +@kindex set sh calling-convention @var{convention} +@cindex set SH Calling convention +Set the calling-convention used when calling functions from @value{GDBN}. +Allowed values are @samp{gcc}, which is the default setting, and @samp{renesas}. +With the @samp{gcc} setting, functions are called using the @value{NGCC} calling +convention. If the DWARF-2 information of the called function specifies +that the function follows the Renesas calling convention, the function +is called using the Renesas calling convention. If the calling convention +is set to @samp{renesas}, the Renesas calling convention is always used, +regardless of the DWARF-2 information. This can be used to override the +default of @samp{gcc} if debug information is missing, or the compiler +does not emit the DWARF-2 calling convention entry for a function. + +@item show sh calling-convention +@kindex show sh calling-convention +@cindex show SH Calling convention +Show the current calling convention setting. + @end table Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat