From: Daniel Jacobowitz <drow@false.org>
To: David Daney <ddaney@avtrex.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Hardware watchpoint register support for mips-linux.
Date: Mon, 21 Apr 2008 20:03:00 -0000 [thread overview]
Message-ID: <20080421195848.GA24657@caradoc.them.org> (raw)
In-Reply-To: <480CEC37.9060202@avtrex.com>
On Mon, Apr 21, 2008 at 12:34:15PM -0700, David Daney wrote:
> Comments are welcome.
You've made most of my comments already. My only addition is do not
use a new nm-linux.h at all. Everything can be done from the
target_ops in mips-linux-nat.c now.
For infrun.c, can you just use resume instead of target_resume?
There's some GNU formatting issues but nothing huge. Spaces,
newlines before function names in definitions.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-04-21 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 19:46 David Daney
2008-04-21 20:03 ` Daniel Jacobowitz [this message]
2008-04-21 20:34 ` David Daney
2008-04-21 21:14 ` Daniel Jacobowitz
2008-04-21 22:36 ` Maciej W. Rozycki
2008-04-22 3:25 ` David Daney
2008-04-22 20:27 ` Maciej W. Rozycki
2008-04-29 3:47 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421195848.GA24657@caradoc.them.org \
--to=drow@false.org \
--cc=ddaney@avtrex.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox