From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4283 invoked by alias); 21 Apr 2008 12:33:22 -0000 Received: (qmail 4270 invoked by uid 22791); 21 Apr 2008 12:33:21 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Apr 2008 12:33:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6F6FD983DB; Mon, 21 Apr 2008 12:32:59 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5196C9829E; Mon, 21 Apr 2008 12:32:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JnvCc-0007ji-7m; Mon, 21 Apr 2008 08:32:58 -0400 Date: Mon, 21 Apr 2008 14:04:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: MI testsuite fix Message-ID: <20080421123258.GA29008@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200804102102.07722.pedro@codesourcery.com> <20080414182131.GC1968@caradoc.them.org> <200804211235.58900.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804211235.58900.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00426.txt.bz2 On Mon, Apr 21, 2008 at 12:35:58PM +0100, Pedro Alves wrote: > Ok, that's what the attached does. Regtested on > x86_64-unknown-linux-gnu, and confirmed that is also fixes the > async MI testsuite on x86 due to the gate page warning. > > BTW, What is it that won't work with the look for .text first? Beats me. But it probably means find_lowest_section doesn't work on some platforms. e.g. the SEC_THREAD_LOCAL thing but that problem is much newer than this code. > > I'd also > > approve a patch to reuse some of the qOffsets machinery for this, but > > that would take more testing... if you want to look at that, > > keep in mind that SEC_LOAD doesn't mean the VMA is useful; you > > also need to check !SEC_THREAD_LOCAL. > > Now you've lost me. This is mapping absolute section addresses > to section offsets. It doesn't seem symfile_map_offsets_to_segments > or objfile_relocate would give any help here? Well, anything that just carries offsets forwards from the previous section is suspect. If the user gives us the addresses of .text and .data, it'd be nice to move the containing segments appropriately. > 2008-04-21 Pedro Alves > > * symfile.c (syms_from_objfile): Don't warn if lowest loadable > section is not a code section. OK. -- Daniel Jacobowitz CodeSourcery