From: csilvers@google.com (Craig Silverstein)
To: drow@false.org
Cc: bauerman@br.ibm.com, gdb-patches@sourceware.org
Subject: Re: Patch to handle compressed sections
Date: Sat, 19 Apr 2008 00:32:00 -0000 [thread overview]
Message-ID: <20080418212806.28E4C3F24C4@localhost> (raw)
In-Reply-To: <20080417190324.GA21743@caradoc.them.org> (message from Daniel Jacobowitz on Thu, 17 Apr 2008 15:03:24 -0400)
} I see. Well, you could use bfd_getb32 twice... I just felt that the
} eight copies of that line were excessive.
Then you'd do something like
size = (a << 32) + b;
which likewise won't work well (well, will give a compiler warning) on
32-bit systems.
I agree the code ends up being verbose, but it's pretty
straightforward and robust. Would you be ok with the code going in
the way it is now?
craig
next prev parent reply other threads:[~2008-04-19 0:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 23:05 Craig Silverstein
2008-03-26 16:10 ` Thiago Jung Bauermann
2008-03-26 17:40 ` Craig Silverstein
2008-03-26 18:01 ` Daniel Jacobowitz
2008-03-26 18:36 ` Craig Silverstein
2008-04-01 14:28 ` Daniel Jacobowitz
2008-04-02 0:38 ` Craig Silverstein
2008-04-02 12:27 ` Daniel Jacobowitz
2008-04-02 12:51 ` Craig Silverstein
2008-04-02 14:13 ` Andreas Schwab
2008-04-03 7:38 ` Craig Silverstein
2008-04-03 8:45 ` Craig Silverstein
2008-04-03 11:01 ` Pedro Alves
2008-04-03 11:10 ` Pedro Alves
2008-04-03 21:43 ` Craig Silverstein
2008-04-04 1:28 ` Craig Silverstein
2008-04-15 6:16 ` Craig Silverstein
2008-04-17 16:24 ` Daniel Jacobowitz
2008-04-17 20:57 ` Craig Silverstein
2008-04-17 21:09 ` Daniel Jacobowitz
2008-04-19 0:32 ` Craig Silverstein [this message]
2008-04-19 0:13 ` Daniel Jacobowitz
2008-04-19 0:32 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418212806.28E4C3F24C4@localhost \
--to=csilvers@google.com \
--cc=bauerman@br.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox