From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55248-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7362 invoked by alias); 17 Apr 2008 21:34:33 -0000
Received: (qmail 7353 invoked by uid 22791); 17 Apr 2008 21:34:33 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 21:34:13 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id C966D983D6; 	Thu, 17 Apr 2008 21:34:11 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 58A50982C4; 	Thu, 17 Apr 2008 21:34:11 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1JmbkA-0002FN-GI; Thu, 17 Apr 2008 17:34:10 -0400
Date: Thu, 17 Apr 2008 22:01:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Doug Evans <dje@google.com>, Michael Snyder <msnyder@specifix.com>, 	Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] mixed source+assembly from cli disassemble
Message-ID: <20080417213410.GA8342@caradoc.them.org>
Mail-Followup-To: Joel Brobecker <brobecker@adacore.com>, 	Doug Evans <dje@google.com>, Michael Snyder <msnyder@specifix.com>, 	Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
References: <20080404003857.A5A451C72B9@localhost> <20080416185535.GB3626@adacore.com> <e394668d0804161525t337703a6if245920db61bc225@mail.gmail.com> <20080417212519.GD12735@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080417212519.GD12735@adacore.com>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00372.txt.bz2

On Thu, Apr 17, 2008 at 02:25:19PM -0700, Joel Brobecker wrote:
> > +      if (*arg == '\0')
> > +	error (_("Missing modifier."));
> > +
> > +      while (*arg && ! isspace (*arg))
> > +	{
> > +	  switch (*arg++)
> > +	    {
> > +	    case 'm':
> > +	      mixed_source_and_assembly = 1;
> > +	      break;
> > +	    default:
> > +	      error (_("Invalid disassembly modifier."));
> > +	    }
> > +	}
> > +
> > +      while (isspace (*arg))
> > +	++arg;
> 
> The formatting looks weird, because some of the lines (the "while" lines
> for instance) are using spaces instead of tabs. Could you fix that to
> use TABs, please?

It looks right to me.  It just gets weirder and weirder as you add
more levels of email quoting.

-- 
Daniel Jacobowitz
CodeSourcery