From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29144 invoked by alias); 17 Apr 2008 21:16:06 -0000 Received: (qmail 29116 invoked by uid 22791); 17 Apr 2008 21:16:03 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 21:15:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 625362AA26B; Thu, 17 Apr 2008 17:15:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tpY9BcnQl5dF; Thu, 17 Apr 2008 17:15:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 211C32AA268; Thu, 17 Apr 2008 17:15:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1BE7EE7ACD; Thu, 17 Apr 2008 14:15:42 -0700 (PDT) Date: Thu, 17 Apr 2008 21:25:00 -0000 From: Joel Brobecker To: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Report the original location specification for a breakpoint. Message-ID: <20080417211542.GC12735@adacore.com> References: <200804151434.57665.vladimir@codesourcery.com> <20080417025749.GA18352@caradoc.them.org> <200804171359.09556.vladimir@codesourcery.com> <20080417174642.GO17488@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080417174642.GO17488@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00365.txt.bz2 > By the way, here's where that duplicate addr= came from in GDB 6.8: > > if (header_of_multiple) > ui_out_field_string (uiout, "addr", ""); > if (b->loc == NULL || loc->shlib_disabled) > ui_out_field_string (uiout, "addr", ""); > else > ui_out_field_core_addr (uiout, "addr", loc->address); > > Should that be else if? ARGH#&! That's my fault. I think so, I think I meant "else if". I don't see why we couldn't have header_of_multiple and loc->shlib_disabled set at the same time. Let me know if you'd like me to fix this. -- Joel