From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28108 invoked by alias); 17 Apr 2008 18:58:38 -0000 Received: (qmail 28096 invoked by uid 22791); 17 Apr 2008 18:58:38 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 18:58:10 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id m3HIvuV5029817; Thu, 17 Apr 2008 19:57:56 +0100 Received: from localhost (meta.corp.google.com [172.22.108.53]) by zps76.corp.google.com with ESMTP id m3HIvqO3003958; Thu, 17 Apr 2008 11:57:52 -0700 Received: by localhost (Postfix, from userid 500) id 244673F23EF; Thu, 17 Apr 2008 11:57:52 -0700 (PDT) To: drow@false.org CC: bauerman@br.ibm.com, gdb-patches@sourceware.org In-reply-to: <20080417161526.GF17488@caradoc.them.org> (message from Daniel Jacobowitz on Thu, 17 Apr 2008 12:15:26 -0400) Subject: Re: Patch to handle compressed sections References: <1206547779.29533.43.camel@localhost.localdomain> <20080326173918.E6D063F25E8@localhost> <20080326180132.GB10127@caradoc.them.org> <20080326183538.346243F25E8@localhost> <20080401140953.GD12753@caradoc.them.org> <20080402000638.1BD1B3F25EF@localhost> <20080402001637.GA18178@caradoc.them.org> <20080403054128.A45A43F25F0@localhost> <20080403064309.5454D3F25F0@localhost> <20080414234559.A3AA03F23CF@localhost> <20080417161526.GF17488@caradoc.them.org> Message-Id: <20080417185752.244673F23EF@localhost> Date: Thu, 17 Apr 2008 20:57:00 -0000 From: csilvers@google.com (Craig Silverstein) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00360.txt.bz2 } Space before parenthesis. Doh, and I was so careful looking for all of those! } You can use bfd_getb64. Yeah, we had some debate about that internally. The issue is that bfd_getb64 crashes on machines without a 64-bit int type. That seemed unnecessarily harsh here, especially since in practice section sizes will never be longer than 32 bits. Do you feel that strongly about it? I'd be more comfortable with code that didn't make 32-bit assumptions. I can comment it if that will help. } Use the sourceware.org URL instead, please. Sure thing. } Do you have write access? If not, request it using the sourceware } form - if you have write access to binutils then you already do. I don't have write access. I've requested it. } The other things needed for this feature are, IMO: Makes sense to me. Should that be part of this patch, or is it ok to do it in a followup patch? } The other thing I very much want is an objcopy option to compress } DWARF sections, but that's clearly beyond the call of duty. That } will let GNU ld users take advantage of this and is probably easier } than teaching GNU ld to compress .debug_info (though that would be } nice, too). Makes sense. Further plans, if we ever get around to it, include adding support to readelf, objdump, and addr2line, and adding support to as to generate compressed sections in .o files (obviously, this will require a linker that knows how to deal with that, so it's a longer-term plan). I'll add objcopy to the list. craig