From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3064 invoked by alias); 17 Apr 2008 17:28:28 -0000 Received: (qmail 3056 invoked by uid 22791); 17 Apr 2008 17:28:28 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 17:28:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 40EB0983D6; Thu, 17 Apr 2008 17:28:02 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2B66F982C4; Thu, 17 Apr 2008 17:28:02 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JmXtx-0001h0-Gh; Thu, 17 Apr 2008 13:28:01 -0400 Date: Thu, 17 Apr 2008 17:47:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE Message-ID: <20080417172801.GM17488@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <20080228135240.GA8988@caradoc.them.org> <200802281657.m1SGv67A001187@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802281657.m1SGv67A001187@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00354.txt.bz2 On Thu, Feb 28, 2008 at 05:57:06PM +0100, Ulrich Weigand wrote: > - There was a conditional check for fpscr in ppc_cannot_store_register; > but as this routine is never called for fpscr in SPE mode, the check > seems superfluous and I just removed it. This doesn't seem to be true. gdbserver: Unknown register fpscr requested There's no code to use PPC_PTRACE_GETREGS, so we do in fact reach here. I'm retesting with /* Some kernels do not allow us to store fpscr. */ if (!(ppc_hwcap & PPC_FEATURE_HAS_SPE) && regno == find_regno ("fpscr")) return 2; -- Daniel Jacobowitz CodeSourcery