From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1181 invoked by alias); 16 Apr 2008 23:10:01 -0000 Received: (qmail 1139 invoked by uid 22791); 16 Apr 2008 23:10:00 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 23:09:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DC977982C4; Wed, 16 Apr 2008 23:09:37 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9D2BD98278; Wed, 16 Apr 2008 23:09:35 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JmGkw-0001nT-QS; Wed, 16 Apr 2008 19:09:34 -0400 Date: Thu, 17 Apr 2008 00:19:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/stabs] fix failed assertion during replacement of undefined type Message-ID: <20080416230934.GA6274@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080403212947.GA24753@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080403212947.GA24753@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00319.txt.bz2 On Thu, Apr 03, 2008 at 02:29:47PM -0700, Joel Brobecker wrote: > The compiler ended up emitting the following debugging info for this > type, which is incomplete: > > .stabs "pck__data_t:t(0,32)=B(0,33)=xepck__data_t:",128,0,3,0 I think we should simply refuse this. It's circular and obviously broken. We have a reference to a named type and the reference is clearly intended to be to a non-volatile type, so GDB blowing up is not entirely unreasonable. That said, as you know, I care very little about the pathological cases in our stabs parser; since no one more knowledgeable has stepped up to object, this seems fine to commit. -- Daniel Jacobowitz CodeSourcery