From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21595 invoked by alias); 16 Apr 2008 08:12:18 -0000 Received: (qmail 21586 invoked by uid 22791); 16 Apr 2008 08:12:17 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 08:12:00 +0000 Received: (qmail 2800 invoked from network); 16 Apr 2008 08:11:57 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Apr 2008 08:11:57 -0000 From: Vladimir Prus To: Aleksandar Ristovski Subject: Re: [patch] fix for PR2424 Date: Wed, 16 Apr 2008 13:17:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com, nickrob@snap.net.nz References: <4804BF23.10505@qnx.com> In-Reply-To: <4804BF23.10505@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804161211.55127.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00303.txt.bz2 On Tuesday 15 April 2008 18:43:47 Aleksandar Ristovski wrote: > Daniel Jacobowitz wrote: > > On Mon, Apr 14, 2008 at 10:41:38AM -0400, Aleksandar Ristovski wrote: > >> ping? > > > > Thanks. The most recent version of this patch (code + testsuite) is OK. > > > > Please mention the PR at the top of the changelog entry, like this: > > > > DATE NAME > > > > PR gdb/2424 > > * infrun.c (some change): .... > > > > Then if you include that line in the commit message, the changelog > > entry is automatically appended to the PR audit trail. > > > > Shouldn't the disp="del" field be described in the manual? If so, > > that can be a separate patch. > > > Committed. > > NOTE1 (reminder): With this patch, we have new field in the *stopped > message, > when "reason == breakpoint-hit" - we will have "disp" field printed; the > value > of the field will be exactly the same as the value printed when the > breakpoint > was created. > > NOTE2: Due to quite significant rework of certain functions in > mi-support.exp, > committed diff for testsuite is not exactly the same as the one I posted. I > took > liberty to commit anyway since the changes are functionally the same; note > the > slightly awkward syntax for "mi_expect_stop" call, namely the "extra" > argument > which now must be something like { "" "disp=\"keep\"" } - I don't think it's > too > bad (it can be beautified later). Can you post the final patch that was checked in, so that I glance on testsuite changes? - Volodya