From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29293 invoked by alias); 15 Apr 2008 20:32:51 -0000 Received: (qmail 29284 invoked by uid 22791); 15 Apr 2008 20:32:50 -0000 X-Spam-Check-By: sourceware.org Received: from host0.dyn.jankratochvil.net (HELO host0.dyn.jankratochvil.net) (89.250.240.59) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Apr 2008 20:32:22 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id m3FKVuWG019458; Tue, 15 Apr 2008 22:31:57 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m3FKVsbW019454; Tue, 15 Apr 2008 22:31:54 +0200 Date: Tue, 15 Apr 2008 22:14:00 -0000 From: Jan Kratochvil To: Daniel Jacobowitz Cc: Roland McGrath , Doug Evans , GDB Patches , mark.kettenis@xs4all.nl Subject: Re: [patch] Fix Linux attach to signalled/stopped processes Message-ID: <20080415203153.GA19151@host0.dyn.jankratochvil.net> References: <20080401223012.GA14076@host0.dyn.jankratochvil.net> <20080410153735.GD21662@caradoc.them.org> <20080410154839.GA5375@host0.dyn.jankratochvil.net> <20080410231205.2DBFD26F992@magilla.localdomain> <20080411161824.GA4183@host0.dyn.jankratochvil.net> <20080412000155.7F07A26FA5E@magilla.localdomain> <20080414143448.GA32227@caradoc.them.org> <20080414150919.GB32227@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20080414150919.GB32227@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00299.txt.bz2 --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1154 Hi, please apply the attached patch to the testcase as this workaround is no longer required with your GDB code patch variant. On Mon, 14 Apr 2008 17:09:19 +0200, Daniel Jacobowitz wrote: ... > Big thanks to Jeff Johnston and Jan Kratochvil for the original work, > Roland for advice, Pedro for async mode fixups, and Doug for prodding > me to look at this issue again. Please fix the authorship of the patch as there is no significant line of code of mine left there. 2008-04-14 Daniel Jacobowitz Pedro Alves Based on work by Jan Kratochvil and Jeff Johnston . ... 2008-04-14 Jan Kratochvil Daniel Jacobowitz * gdb.threads/attach-into-signal.c, gdb.threads/attach-into-signal.exp, gdb.threads/attach-stopped.c, gdb.threads/attach-stopped.exp, gdb.threads/attachstop-mt.c, gdb.threads/attachstop-mt.exp: New. The attachment part works for me OK; I hope also the detach-as-stopped part gets imported later to make gdb_gcore.sh of a stopped process transparent. Regards, Jan --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="attach-into-signal.c-fix.patch" Content-length: 567 --- ./gdb/testsuite/gdb.threads-upstream/attach-into-signal.c 2008-04-15 21:57:13.000000000 +0200 +++ ./gdb/testsuite/gdb.threads/attach-into-signal.c 2008-04-15 22:15:24.000000000 +0200 @@ -40,10 +40,8 @@ static void *func (void *arg) raise (SIGALRM); - /* This should be NOTREACHED but sometimes it is reached - Bug 427860. - We never get here without ptrace(2). It may also be a kernel bug. */ - for (;;) - pause (); + /* We must not get past this point, either in a free standing or debugged + state. */ abort (); /* NOTREACHED */ --IS0zKkzwUGydFO0o--