From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25072 invoked by alias); 15 Apr 2008 14:57:16 -0000 Received: (qmail 25046 invoked by uid 22791); 15 Apr 2008 14:57:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Apr 2008 14:56:54 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 227F998278; Tue, 15 Apr 2008 14:56:53 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 03B1A98149; Tue, 15 Apr 2008 14:56:53 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jlmaa-0003CQ-6i; Tue, 15 Apr 2008 10:56:52 -0400 Date: Tue, 15 Apr 2008 15:25:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: Vladimir Prus , gdb-patches@sources.redhat.com, nickrob@snap.net.nz Subject: Re: [patch] fix for PR2424 Message-ID: <20080415145652.GA12004@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , Vladimir Prus , gdb-patches@sources.redhat.com, nickrob@snap.net.nz References: <4804BF23.10505@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4804BF23.10505@qnx.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00290.txt.bz2 On Tue, Apr 15, 2008 at 10:43:47AM -0400, Aleksandar Ristovski wrote: > NOTE2: Due to quite significant rework of certain functions in > mi-support.exp, > committed diff for testsuite is not exactly the same as the one I posted. I > took > liberty to commit anyway since the changes are functionally the same; note > the > slightly awkward syntax for "mi_expect_stop" call, namely the "extra" > argument > which now must be something like { "" "disp=\"keep\"" } - I don't think it's > too > bad (it can be beautified later). Committing anyway is fine. When you commit a modified version of a patch, though, please post the final version for the list archives. Thanks. That way anyone whose code is affected can see the changes. > NOTE3: In mi-support.exp (mi_expect_stop), I put argument "after_reason" to > be > after the reason (I couldn't find it being used anywhere anyway, so this > should > be a safe change). Vladimir presumably has plans for it :-) > NOTE4: Documentation is not updated (I will try to do that now and submit > the > diff for approval). Thanks. -- Daniel Jacobowitz CodeSourcery