From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15574 invoked by alias); 10 Apr 2008 14:21:01 -0000 Received: (qmail 15532 invoked by uid 22791); 10 Apr 2008 14:20:59 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Apr 2008 14:20:32 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6F47F980F7; Thu, 10 Apr 2008 14:20:30 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 58C0B98060; Thu, 10 Apr 2008 14:20:30 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jjxdd-00064Q-Nq; Thu, 10 Apr 2008 10:20:29 -0400 Date: Thu, 10 Apr 2008 15:22:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: Nick Roberts , gdb-patches@sourceware.org Subject: Re: [RFC] Using bt command in async mode Message-ID: <20080410142029.GB21662@caradoc.them.org> Mail-Followup-To: Tom Tromey , Nick Roberts , gdb-patches@sourceware.org References: <18417.38670.195071.81191@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00190.txt.bz2 On Tue, Apr 01, 2008 at 11:53:52AM -0600, Tom Tromey wrote: > What do you think of this? It moves the flag into the command object > instead of hard-coding it into a big 'if'. Seems like this will be just as awkward in the long term, but it's an improvement. OK if it tested fine. > ChangeLog: > 2008-04-01 Tom Tromey > > * cli/cli-decode.h (CMD_ASYNC_OK): New define. > (set_cmd_async_ok, get_cmd_async_ok): Declare. > * cli/cli-decode.c (set_cmd_async_ok): New function. > (get_cmd_async_ok): New function. > * cli/cli-cmds.c (init_cli_cmds): Mark "pwd", "help", "info", and > "show" as async-ok. > * top.c (execute_command): Use get_cmd_async_ok. > * infcmd.c: Include cli/cli-decode.h. > (_initialize_infcmd): Mark "interrupt" as async-ok. > * Makefile.in (infcmd.o): Depend on cli_decode_h. -- Daniel Jacobowitz CodeSourcery