From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23710 invoked by alias); 10 Apr 2008 08:16:12 -0000 Received: (qmail 23613 invoked by uid 22791); 10 Apr 2008 08:16:11 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Apr 2008 08:15:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CD5B92A9D90; Thu, 10 Apr 2008 04:15:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7jFd5anWk3q2; Thu, 10 Apr 2008 04:15:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8348D2A9E68; Thu, 10 Apr 2008 04:15:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 24DC7E7ACD; Thu, 10 Apr 2008 01:15:49 -0700 (PDT) Date: Thu, 10 Apr 2008 12:35:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [RFA] mixed source+assembly from cli disassemble Message-ID: <20080410081549.GA3589@adacore.com> References: <20080404003857.A5A451C72B9@localhost> <1207776316.31772.410.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1207776316.31772.410.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00186.txt.bz2 > Going on a week... > No other comments, pro or con? I really like the idea, it's something that I often wished we'd have (and often asked for in graphical front-ends). I was going to review the patch, but wanted to ask others to comment on the user interface first. Once we agree on the syntax, then I can review the patch itself. Doug suggests to use an optional "/s" modifier. For instance: (gdb) disassemble ADDR -> regular assembly listing (gdb) disassemble /s ADDR -> intermixed source+assembly listing Is that OK with everyone? It's pretty consistent with what we do for the print command, so I like it. -- Joel