From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17565 invoked by alias); 3 Apr 2008 18:13:07 -0000 Received: (qmail 17557 invoked by uid 22791); 3 Apr 2008 18:13:07 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 03 Apr 2008 18:12:47 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 87416983BE; Thu, 3 Apr 2008 18:12:45 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5E74098278; Thu, 3 Apr 2008 18:12:45 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JhTvY-00023R-94; Thu, 03 Apr 2008 14:12:44 -0400 Date: Thu, 03 Apr 2008 18:58:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: GDB Patches Subject: Re: [RFA] remove free_contents Message-ID: <20080403181244.GA7857@caradoc.them.org> Mail-Followup-To: Doug Evans , GDB Patches References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00074.txt.bz2 On Thu, Apr 03, 2008 at 10:54:48AM -0700, Doug Evans wrote: > Either the comment is incomplete (i.e. some names are not allocated > on an objfile_obstack), or the code is wrong (or in this case, outdated). Both possible, I think, as long as the name has lifetime at least as long as the objfile_obstack. It could come from mmaped dwarf sections, for instance (if we get around to making that work... I see that conversation on a patch to do this trailed off). > 2008-04-03 Doug Evans > > * symtab.h (enum free_code): Delete free_contents, unused. > * symmisc.c (free_symtab_block): Delete. > (free_symtab, case free_code): Delete. OK, thanks. -- Daniel Jacobowitz CodeSourcery