From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19556 invoked by alias); 2 Apr 2008 18:18:32 -0000 Received: (qmail 19500 invoked by uid 22791); 2 Apr 2008 18:18:30 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Apr 2008 18:17:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DDB5E983BE; Wed, 2 Apr 2008 18:17:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 98CE798149; Wed, 2 Apr 2008 18:17:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jh7Wq-0003vb-U9; Wed, 02 Apr 2008 14:17:45 -0400 Date: Wed, 02 Apr 2008 18:50:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME Message-ID: <20080402181744.GA15035@caradoc.them.org> Mail-Followup-To: Michael Snyder , Vladimir Prus , gdb-patches@sources.redhat.com References: <6D19CA8D71C89C43A057926FE0D4ADAA04290FFC@ecamlmw720.eamcs.ericsson.se> <1207159695.31772.122.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1207159695.31772.122.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00044.txt.bz2 On Wed, Apr 02, 2008 at 11:08:15AM -0700, Michael Snyder wrote: > On Wed, 2008-04-02 at 17:22 +0400, Vladimir Prus wrote: > > Marc Khouzam wrote: > > > > > 2008-04-01 Marc Khouzam > > > > > > * mi/mi-cmd-var.c: Include "mi-getopt.h". > > > (mi_parse_format): New. Factored out from mi_cmd_var_set_format. > > > (mi_cmd_var_set_format): Use new mi_parse_format. > > > (mi_cmd_var_evaluate_expression): Support for -f option to specify > > > format. > > > * Makefile.in (mi-cmd-var.o): Update dependencies. > > > > > > * varobj.h (varobj_get_formatted_value): Declare. > > > * varobj.c (my_value_of_variable): Added format parameter. > > > (cplus_value_of_variable): Likewise. > > > (java_value_of_variable): Likewise. > > > (*(value_of_variable)): Likewise. > > > > Is '*(value_of_variable)' really a name of a function? :-) > > It is, actually -- but not in varobj.c. Thanks for raising this. > Marc, we prefer not to have identifiers or file names abbreviated > in changelogs. Context is: /* The current value of VAR. */ char *(*value_of_variable) (struct varobj * var); It's a member of struct language_specifick which is how we usually attribute the changelog entry. -- Daniel Jacobowitz CodeSourcery