From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23964 invoked by alias); 28 Mar 2008 16:00:14 -0000 Received: (qmail 23944 invoked by uid 22791); 28 Mar 2008 16:00:10 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Mar 2008 15:59:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2SFxdCU125512 for ; Fri, 28 Mar 2008 15:59:39 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2SFxcr52326610 for ; Fri, 28 Mar 2008 16:59:38 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2SFxbTj006285 for ; Fri, 28 Mar 2008 16:59:38 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m2SFxbIA006282; Fri, 28 Mar 2008 16:59:37 +0100 Message-Id: <200803281559.m2SFxbIA006282@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 28 Mar 2008 16:59:37 +0100 Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple To: deuling@de.ibm.com (Markus Deuling) Date: Fri, 28 Mar 2008 16:00:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz), gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <47ECB74F.9020501@de.ibm.com> from "Markus Deuling" at Mar 28, 2008 10:15:59 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00467.txt.bz2 Markus Deuling wrote: > diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp > --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100 > +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-28 09:53:47.000000000 +0100 > @@ -200,9 +200,17 @@ gdb_test "finish" "" "finish" > # Mailbox Test > # 'info spu mailbox' should be empty. > c_to "Marker Mbox" > -gdb_test "info spu mailbox" \ > - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \ > - "info spu mailbox" > +set msg "info spu mailbox" > +gdb_test_multiple "info spu mailbox" $msg { > + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" { > + pass $msg > + } > + -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" { > + # Older kernels had a bug that caused them to return arbitrary values > + # when attempting to read from an empty mailbox via spufs. > + xfail $msg > + } > +} > > # 'info spu mailbox' should now contain data. > c_to "Marker MboxEnd" Assuming you tested the behaviour on both old and new kernels, this is OK with me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com