Re: [patch] Remove comments from user_code in gdb_test_multiple

Daniel Jacobowitz
2008-03-27T15:55:54Z

On Thu, Mar 27, 2008 at 04:46:36PM +0100, Markus Deuling wrote:
> # Older kernels had a bug that caused them to return arbitrary values when
> # attempting to read from an empty mailbox via spufs.
> -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" {
> xfail "$msg"
> }
> }
>
> What do you think about the spu info mailbox patch then ? Move the comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have the comments in the right place?

That becomes:

> -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" {
> # Older kernels had a bug that caused them to return arbitrary values when
> # attempting to read from an empty mailbox via spufs.
> xfail "$msg"
> }

--
Daniel Jacobowitz
CodeSourcery