From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54798-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3772 invoked by alias); 27 Mar 2008 15:55:54 -0000
Received: (qmail 3758 invoked by uid 22791); 27 Mar 2008 15:55:54 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 27 Mar 2008 15:55:34 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 1FE6A983AA; 	Thu, 27 Mar 2008 15:55:33 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id F3F61983A1; 	Thu, 27 Mar 2008 15:55:32 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1JeuRw-0002SW-6j; Thu, 27 Mar 2008 11:55:32 -0400
Date: Thu, 27 Mar 2008 15:55:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, 	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple
Message-ID: <20080327155532.GA9433@caradoc.them.org>
Mail-Followup-To: Markus Deuling <deuling@de.ibm.com>, 	Ulrich Weigand <uweigand@de.ibm.com>, 	GDB Patches <gdb-patches@sourceware.org>
References: <47EBBBFA.4010700@de.ibm.com> <20080327153159.GA8060@caradoc.them.org> <47EBC15C.6070306@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47EBC15C.6070306@de.ibm.com>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00440.txt.bz2

On Thu, Mar 27, 2008 at 04:46:36PM +0100, Markus Deuling wrote:
>    # Older kernels had a bug that caused them to return arbitrary values when
>    # attempting to read from an empty mailbox via spufs.
>    -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" {
>         xfail "$msg"
>    }
> }
>
> What do you think about the spu info mailbox patch then ? Move the comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have the comments in the right place?

That becomes:

>     -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" {
> 	# Older kernels had a bug that caused them to return arbitrary values when
> 	# attempting to read from an empty mailbox via spufs.
> 	xfail "$msg"
>     }

-- 
Daniel Jacobowitz
CodeSourcery