Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: cleanup mi error message handling
Date: Mon, 24 Mar 2008 22:39:00 -0000	[thread overview]
Message-ID: <20080324223840.GA20307@caradoc.them.org> (raw)
In-Reply-To: <18408.9553.683746.929167@kahikatea.snap.net.nz>

On Tue, Mar 25, 2008 at 10:04:01AM +1200, Nick Roberts wrote:
> I think sometimes errors are just needed when debugging the frontend, e.g.,
> 
>   -thread-select
>   ^error,msg="mi_cmd_thread_select: USAGE: threadnum."
>   (gdb) 
> 
> where one error message is sufficient.  Here I think Gdb is trying to mimic
> perror by giving the name of the C procedure, but I think it's not desirable as
> this gets printed due to a frontend error, not a Gdb error.  So I would like to
> see:
> 
>   -thread-select
>   ^error,msg="USAGE: threadnum."
>   (gdb) 

I agree.

> At other times duplicated error messages are desirable, e.g.,
> 
>   -exec-continue 
>   ^running
>   (gdb) 
>   &"The program is not being run.\n"
>   ^error,msg="The program is not being run."
> 
> because the first goes to the console for the user to see, the second to
> the frontend to be handled as appropriate.

Could you explain why the duplication here is good?  It seems to me
that if the front end wants to display this error to the user in the
console, it can do so anyway, but it shouldn't have to.  Maybe this
requires a version bump, I don't know.

In Eclipse, this duplication leads to a bunch of error messages that
pop up in the console pane which don't come from anything the user
did.  It's very confusing.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-24 22:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24 18:30 Pedro Alves
2008-03-24 19:08 ` Pedro Alves
2008-03-24 22:04 ` Nick Roberts
2008-03-24 22:39   ` Daniel Jacobowitz [this message]
2008-03-24 23:37     ` Nick Roberts
2008-03-25  1:00       ` Daniel Jacobowitz
2008-03-25  1:29         ` Nick Roberts
2008-03-25  2:12           ` Daniel Jacobowitz
2008-03-29 14:22             ` Vladimir Prus
2008-03-30  5:13               ` Nick Roberts
2008-03-30  6:06                 ` Vladimir Prus
2008-03-31  0:46                   ` Nick Roberts
2008-03-31  1:59                     ` Daniel Jacobowitz
2008-03-31  2:23                     ` Nick Roberts
2008-03-31  5:07                     ` Vladimir Prus
2008-03-31  6:36                       ` Nick Roberts
2008-03-31  7:10                         ` Vladimir Prus
2008-03-31 15:17                         ` Pedro Alves
2008-03-31 11:24                           ` Pedro Alves
2008-04-01  2:00                     ` Pedro Alves
2008-04-01  0:18                       ` Pedro Alves
2008-04-01 13:17                       ` Nick Roberts
2008-04-01  3:28                         ` Nick Roberts
2008-03-25  3:52   ` Pedro Alves
2008-04-04 13:33 ` Vladimir Prus
2008-04-04 23:08   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324223840.GA20307@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox