Re: [patch] Fix testsuite annotate-quit race (PR 544)

Daniel Jacobowitz
2008-03-24T02:58:59Z

On Mon, Mar 24, 2008 at 12:06:30PM +1200, Nick Roberts wrote:
> > Anyway, since the patch is clearly at fault I have reverted it.
> > Nick, Jan, thank you.
>
> With this setting, for some reason this patch means that Gdb doesn't display
> the prompt but everything else gets displayed:

Thanks, that's very helpful.

What I think is happening is that rl_redisplay has some optimizations
which cause it not to redisplay. And since we have a custom function
installed readline isn't calling the alternate hooks that force
display. So rl_redisplay does not actually meet the interface
associated with rl_redisplay_function despite being its default
value. Nasty.

We can work around that, probably by forcing redisplay and by
accepting slightly less optimized redraw, but it seems a bit lame...

We could patch our local readline with Jan's patch, which would fix it
for anyone using the included readline binary. Or just KFAIL the test
until we merge a new readline version. Thoughts?

--
Daniel Jacobowitz
CodeSourcery