Re: [patch] Fix testsuite annotate-quit race (PR 544)

Jan Kratochvil
2008-03-23T16:44:23Z

On Sun, 23 Mar 2008 17:30:27 +0100, Daniel Jacobowitz wrote:
...
> I tried running gdb under nohup and it worked fine. I tried it in
> Emacs too, and that worked fine:

Confirmed the patch broke emacs-22.1-8.fc8.x86_64 (M-x shell ...). readline
checks for custom RL_REDISPLAY_FUNCTION and behaves differently in such case.
Sorry for suggesting RL_REDISPLAY_FUNCTION - I did not verify it more.
Now just to find out how to supply GDB_RL_REDISPLAY simulating the original
behavior.

latest GDB:
rt_sigaction(SIGWINCH, {0x5f9025, [], SA_RESTORER|SA_RESTART, 0x3b98630f30}, {0x4ab21a, [], SA_RESTORER, 0x3b98630f30}, 8) = 0
rt_sigprocmask(SIG_BLOCK, [INT], [CHLD], 8) = 0
rt_sigprocmask(SIG_SETMASK, [CHLD], NULL, 8) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
poll([{fd=3, events=POLLIN}, {fd=0, events=POLLIN, revents=POLLIN}], 2, -1) = 1
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
read(0, "q", 1) = 1

reverted patch:
rt_sigaction(SIGWINCH, {0x5f8fb5, [], SA_RESTORER|SA_RESTART, 0x3b98630f30}, {0x4ab1aa, [], SA_RESTORER, 0x3b98630f30}, 8) = 0
write(1, "\n\32\32pre-prompt\n(gdb) \n\32\32prompt\n", 30) = 30
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
poll([{fd=3, events=POLLIN}, {fd=0, events=POLLIN, revents=POLLIN}], 2, -1) = 1
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
rt_sigprocmask(SIG_BLOCK, NULL, [CHLD], 8) = 0
read(0, "q", 1) = 1

> Does reverting the patch fix the problem?

Yes.

Regards,
Jan