Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list

Daniel Jacobowitz
2008-03-21T21:22:14Z

On Fri, Mar 21, 2008 at 09:33:11PM +0100, Jan Kratochvil wrote:
> On Fri, 21 Mar 2008 20:01:51 +0100, Chet Ramey wrote:
> > I'm looking at the rl_unwind_protect thing a little more closely, and I'm
> > wondering why you didn't use rl_save_state and rl_restore_state
> [snip]
>
> These functions are just not in the info document.
> They could be used to implement the GDB part of the patch
> http://sourceware.org/ml/gdb-patches/2007-06/txt00005.txt
> but it needs to undo the current async-readline patch from Daniel Jacobowitz
> first.
>
> It would keep there the original synchronous readline() call being fully
> backward compatible.

Thanks. I didn't know about those either. Is there anything
currently broken with our readline wrapper that needs fixing, though?
If it's working, I would rather leave it alone. We may in the future
want to really return to the main event loop while we're waiting for
the user to type, so that we can notice target events in async mode.
A blocking call to readline is a problem for that.

--
Daniel Jacobowitz
CodeSourcery