Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list

Chet Ramey
2006-12-02T19:09:25Z

H. J. Lu wrote:

>>> I'm pretty sure this isn't right. I got as far as figuring out that we
>>> should be calling rl_callback_handler_install and
>>> rl_callback_handler_remove at different times, always removing the
>>> handler before calling readline recursively, but I couldn't quite work
>>> out the right conditions.
>> I assume by "this isn't right", you mean my patch may break something.
>> Do you have a testcase? It may get into readline:

Unless the calling application is careful, this code will leave readline
in an inconsistent state in the presence of a longjmp(). It relies on
private state kept local to a single call to readline().

I am leaning towards not including it for that reason.

There should be no reason that the application cannot remove the callback
handler and re-add it before calling readline synchronously, as Daniel or
H.J. suggested. The application is the only one in a position to know
which is right.

Chet

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
Live Strong. No day but today.
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/