From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8616 invoked by alias); 21 Mar 2008 21:22:14 -0000 Received: (qmail 8605 invoked by uid 22791); 21 Mar 2008 21:22:13 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 21:21:46 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 04830983BF; Fri, 21 Mar 2008 21:21:45 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E1BBE98278; Fri, 21 Mar 2008 21:21:44 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JcogK-0005vX-6Z; Fri, 21 Mar 2008 17:21:44 -0400 Date: Fri, 21 Mar 2008 21:22:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Nick Roberts Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list Message-ID: <20080321212144.GA18716@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org, Nick Roberts References: <18019.18081.448928.93993@kahikatea.snap.net.nz> <20070604010633.GA927@caradoc.them.org> <20070626131336.GA8960@host0.dyn.jankratochvil.net> <20080321203311.GA4245@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080321203311.GA4245@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00319.txt.bz2 On Fri, Mar 21, 2008 at 09:33:11PM +0100, Jan Kratochvil wrote: > On Fri, 21 Mar 2008 20:01:51 +0100, Chet Ramey wrote: > > I'm looking at the rl_unwind_protect thing a little more closely, and I'm > > wondering why you didn't use rl_save_state and rl_restore_state > [snip] > > These functions are just not in the info document. > They could be used to implement the GDB part of the patch > http://sourceware.org/ml/gdb-patches/2007-06/txt00005.txt > but it needs to undo the current async-readline patch from Daniel Jacobowitz > first. > > It would keep there the original synchronous readline() call being fully > backward compatible. Thanks. I didn't know about those either. Is there anything currently broken with our readline wrapper that needs fixing, though? If it's working, I would rather leave it alone. We may in the future want to really return to the main event loop while we're waiting for the user to type, so that we can notice target events in async mode. A blocking call to readline is a problem for that. -- Daniel Jacobowitz CodeSourcery