From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16681 invoked by alias); 21 Mar 2008 20:34:09 -0000 Received: (qmail 16669 invoked by uid 22791); 21 Mar 2008 20:34:07 -0000 X-Spam-Check-By: sourceware.org Received: from host0.dyn.jankratochvil.net (HELO host0.dyn.jankratochvil.net) (89.250.240.59) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 20:33:37 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id m2LKXCpl004946; Fri, 21 Mar 2008 21:33:12 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m2LKXBFY004941; Fri, 21 Mar 2008 21:33:11 +0100 Date: Fri, 21 Mar 2008 20:34:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Nick Roberts , Daniel Jacobowitz Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list Message-ID: <20080321203311.GA4245@host0.dyn.jankratochvil.net> References: <18019.18081.448928.93993@kahikatea.snap.net.nz> <20070604010633.GA927@caradoc.them.org> <20070626131336.GA8960@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070626131336.GA8960@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00316.txt.bz2 Reply to: http://sourceware.org/ml/gdb-patches/2007-06/msg00458.html On Tue, 26 Jun 2007 15:13:37 +0200, Jan Kratochvil wrote: ... > (2) Provide a new documented way to abort readline() from a signal handler. > Provided rl_readline_unwind() needed to be called right before longjmp(). > Proposed, patch attached. > + Fully crossplatform, backward compatible. > + Not affecting most of the apps as they do not longjmp() out of readline(). > - New libreadline API function. Upon a recent discussion with the readline maintainer Chet Ramey I was told the support for this method in fact exists in readline: On Fri, 21 Mar 2008 20:01:51 +0100, Chet Ramey wrote: > I'm looking at the rl_unwind_protect thing a little more closely, and I'm > wondering why you didn't use rl_save_state and rl_restore_state [snip] These functions are just not in the info document. They could be used to implement the GDB part of the patch http://sourceware.org/ml/gdb-patches/2007-06/txt00005.txt but it needs to undo the current async-readline patch from Daniel Jacobowitz first. It would keep there the original synchronous readline() call being fully backward compatible. Regards, Jan