From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14159 invoked by alias); 21 Mar 2008 15:32:39 -0000 Received: (qmail 14151 invoked by uid 22791); 21 Mar 2008 15:32:39 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 15:32:08 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5AB7C98298; Fri, 21 Mar 2008 15:32:07 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3A05398278; Fri, 21 Mar 2008 15:32:07 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JcjDy-00073L-He; Fri, 21 Mar 2008 11:32:06 -0400 Date: Fri, 21 Mar 2008 15:32:00 -0000 From: Daniel Jacobowitz To: Chris Demetriou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] fix for rbreak issue w/ "Junk at end of arguments" Message-ID: <20080321153206.GI25307@caradoc.them.org> Mail-Followup-To: Chris Demetriou , gdb-patches@sources.redhat.com References: <2e7be40c0803150118x58bf76c7r4bf67fc61d07c26a@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e7be40c0803150118x58bf76c7r4bf67fc61d07c26a@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00307.txt.bz2 On Sat, Mar 15, 2008 at 01:18:09AM -0700, Chris Demetriou wrote: > If this patch is acceptable, please apply it. (I don't have write access.) Thanks for fixing this. It's OK, modulo our whitespace conventions (space before paren); I fixed that and checked it in. Want write access? If so, fill out the sourceware.org form; it's on the front page of the web site. Oddly the test doesn't fail for me even though I've got an __libc_start_main@plt. It's not setting a breakpoint at the PLT entry... boo, it thinks that comes from a startfile. Another day. -- Daniel Jacobowitz CodeSourcery