From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7849 invoked by alias); 21 Mar 2008 15:16:30 -0000 Received: (qmail 7840 invoked by uid 22791); 21 Mar 2008 15:16:30 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 15:16:10 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F1F3998298; Fri, 21 Mar 2008 15:16:08 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id DD01F98278; Fri, 21 Mar 2008 15:16:08 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JciyW-0006gw-8N; Fri, 21 Mar 2008 11:16:08 -0400 Date: Fri, 21 Mar 2008 15:16:00 -0000 From: Daniel Jacobowitz To: Matt Rice Cc: gdb-patches@sourceware.org Subject: Re: [patch] pr1430 Message-ID: <20080321151608.GG25307@caradoc.them.org> Mail-Followup-To: Matt Rice , gdb-patches@sourceware.org References: <8ba6bed40803141338t4bf3ce57u70c494fa4004ee60@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ba6bed40803141338t4bf3ce57u70c494fa4004ee60@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00305.txt.bz2 On Fri, Mar 14, 2008 at 01:38:12PM -0700, Matt Rice wrote: > here is an attempt at fixing pr1430 > > canonicalizes to file.m:foo or file.m:-[AClass foo] > which is how it knows that foo is a function and it shouldn't attempt > to look up a method > named foo. not sure if this should be done in decode_line_2 based on > language setting? > > so if you move files around or anything you have to reset your > breakpoints, but i would take that over an endless loop. This isn't safe; there might not be a filename. Aren't we getting canonicalized to file.m:-[AClass foo] already? build_canonical_line_spec should do it. A harder version of this problem will come up if you have a non-debuggable symbol named foo. We won't have a filename to put in front of it. So how do we know it's already been canonicalized? This is sort of like what the Apple patch did in the audit trail. -- Daniel Jacobowitz CodeSourcery