Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Pending breakpoints
Date: Fri, 21 Mar 2008 14:46:00 -0000	[thread overview]
Message-ID: <20080321144600.GB25307@caradoc.them.org> (raw)
In-Reply-To: <18372.29471.522929.827100@kahikatea.snap.net.nz>

On Wed, Feb 27, 2008 at 09:14:23AM +1300, Nick Roberts wrote:
>    (gdb) nosharedlibrary 
>    (gdb) info break
>    Num     Type           Disp Enb  Address    What
>    1       breakpoint     keep y    <PENDING>  
> 
> and the last "info break" no longer says what the breakpoint is for.  I don't
> really know when you would unload the shared library, in practice, but I think
> this line should look like the first output from "info break", i.e., include
> sqrt.

I agree that this is wrong.

> The patch below does that.  It's a bit of a guess, though, and I've not run
> the testuite.

Seems good to me.  We do the same in print_one_breakpoint_location.
The patch is OK with a changelog and a full test run.

Even better would be to discard locations when we shlib_disable a
breakpoint, and get rid of the shlib_disable flag.  But doing that may
require that we get rid of shared libraries when we're supposed to.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2008-03-21 14:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 20:24 Nick Roberts
2008-02-26 21:38 ` Daniel Jacobowitz
2008-03-21 14:46 ` Daniel Jacobowitz [this message]
2008-04-03 11:18   ` Nick Roberts
2008-04-03 11:36     ` Andreas Schwab
2008-04-03 13:25     ` Daniel Jacobowitz
2008-04-03 17:55       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080321144600.GB25307@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox