From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10393 invoked by alias); 19 Mar 2008 22:47:16 -0000 Received: (qmail 10385 invoked by uid 22791); 19 Mar 2008 22:47:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 22:46:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 91A6898149; Wed, 19 Mar 2008 22:46:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 58B2B98119; Wed, 19 Mar 2008 22:46:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jc73d-0005mo-53; Wed, 19 Mar 2008 18:46:53 -0400 Date: Wed, 19 Mar 2008 22:47:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Pedro Alves , GDB Patches , Vladimir Prus Subject: Re: [linux] fix stepping over fork in follow-child mode. Message-ID: <20080319224653.GA22160@caradoc.them.org> Mail-Followup-To: Nick Roberts , Pedro Alves , GDB Patches , Vladimir Prus References: <200803182046.46420.pedro@codesourcery.com> <20080318234805.GA14989@caradoc.them.org> <20080319160257.GA31587@caradoc.them.org> <18401.37184.169763.462813@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18401.37184.169763.462813@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00292.txt.bz2 On Thu, Mar 20, 2008 at 10:18:40AM +1200, Nick Roberts wrote: > > /* Building process ids. */ > > > > #define GET_PID(ptid) ptid_get_pid (ptid) > > #define GET_LWP(ptid) ptid_get_lwp (ptid) > > -#define GET_THREAD(ptid) ptid_get_tid (ptid) > > - > > -#define is_lwp(ptid) (GET_LWP (ptid) != 0) > > -#define is_thread(ptid) (GET_THREAD (ptid) != 0) > > > > #define BUILD_LWP(lwp, pid) ptid_build (pid, lwp, 0) > > Why not just put all these in linux-nat.h so there are not duplications in > linux-nat.c? No particular reason; I just left them where they were. I believe they were added to a lot of files when ptid_t was introduced. May as well move them, I'll do that. -- Daniel Jacobowitz CodeSourcery