From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15897 invoked by alias); 19 Mar 2008 10:13:08 -0000 Received: (qmail 15889 invoked by uid 22791); 19 Mar 2008 10:13:08 -0000 X-Spam-Check-By: sourceware.org Received: from router.kulicky.cz (HELO router.kulicky.cz) (213.180.48.211) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 10:12:39 +0000 Received: from host0.dyn.jankratochvil.net ([192.168.76.151]) by router.kulicky.cz (8.13.8/8.13.8) with ESMTP id m2JACaG6018271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 19 Mar 2008 11:12:36 +0100 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id m2JACWr1006020; Wed, 19 Mar 2008 11:12:32 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m2JACVoO006016; Wed, 19 Mar 2008 11:12:31 +0100 Date: Wed, 19 Mar 2008 10:13:00 -0000 From: Jan Kratochvil To: Nick Roberts Cc: bug-readline@gnu.org, gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544) Message-ID: <20080319101231.GA5405@host0.dyn.jankratochvil.net> References: <20080318225436.GA27374@host0.dyn.jankratochvil.net> <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net> <18400.53985.920783.999852@kahikatea.snap.net.nz> <20080319092335.GA1995@host0.dyn.jankratochvil.net> <18400.58139.937426.478457@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18400.58139.937426.478457@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00274.txt.bz2 On Wed, 19 Mar 2008 10:55:39 +0100, Nick Roberts wrote: > I am just worried it will break something for Emacs just as a previous change > that you and Daniel made to readline did. http://sourceware.org/ml/gdb-patches/2006-11/threads.html#00234 http://sourceware.org/ml/gdb-patches/2006-12/threads.html#00009 > It appear to me that the only problem this FAIL is causing is with the actual > running of the testsuite. I would be quite happy if this test was just > removed. Would that work for everyone else? The problem is unrelated to the annotations and there should be a testcase just with the "(gdb) " prompt after the annotations support gets obsoleted/removed. Currently the test described at http://sourceware.org/ml/gdb-patches/2008-03/msg00270.html has different output depending on whether you type CTRL-C early enough (during the "(gdb) " printing) or just later (in poll(2) waiting for input). With the readline patch proposed there the output is always the same. I find it a bug as without the artifical `sleep (1)' delay it is very racy. > but I am just worried it will break something for Emacs just as a previous > change that you and Daniel made to readline did. My original patch requiring a readline change AFAIK did not break anything, unfortunately it did not get accepted for readline. Daniel created an IMO complicated patch to workaround the readline problem without forking readline but unfortunately it brought that regression. I find the regression was in fact only a consequence of the readline interface deficiency. Regards, Jan