From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21093 invoked by alias); 19 Mar 2008 09:31:47 -0000 Received: (qmail 21083 invoked by uid 22791); 19 Mar 2008 09:31:47 -0000 X-Spam-Check-By: sourceware.org Received: from router.kulicky.cz (HELO router.kulicky.cz) (213.180.48.211) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 09:31:29 +0000 Received: from host0.dyn.jankratochvil.net ([192.168.76.151]) by router.kulicky.cz (8.13.8/8.13.8) with ESMTP id m2J9VNcs010781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 19 Mar 2008 10:31:25 +0100 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id m2J9NalH002191; Wed, 19 Mar 2008 10:23:36 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m2J9NZ6D002190; Wed, 19 Mar 2008 10:23:35 +0100 Date: Wed, 19 Mar 2008 09:31:00 -0000 From: Jan Kratochvil To: Nick Roberts Cc: bug-readline@gnu.org, gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544) Message-ID: <20080319092335.GA1995@host0.dyn.jankratochvil.net> References: <20080318225436.GA27374@host0.dyn.jankratochvil.net> <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net> <18400.53985.920783.999852@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18400.53985.920783.999852@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00272.txt.bz2 On Wed, 19 Mar 2008 09:46:25 +0100, Nick Roberts wrote: > > > > PR 544 des gdb.cp/annota2.exp and gdb.cp/annota3.exp sometimes FAIL with: > > > > FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1) > > ... > > > Isn't this a bug in GDB, not a bug in the test? > > > > You are right it is probably better to fix it in readline. > > Annotations are being deprecated and the original bug report is nearly six > years old. As as variation of the old adage, I would suggest that "Since > no-one appears to mind it's broke, don't fix it". The danger of making a fix > in readline, of course, is that you break annotations elsewhere, where it's > more important. * I still face testsuite results flutter making the day-to-day regressions evaluations expensive. Most of the flutters are fixed in gdb-6.8 but still some of them remain, this fix is for one of them. * I do not care much if it FAILs or PASSes but it must not flutter. * I found it is a known PR 544 only after I fixed it. * I fixed it as it was a nuisance reported by the courtesy of Roland McGrath. * As the SIGINT blocking in RL_REDISPLAY fixes the race (1 of 10 cases to 0 of 350 cases during my test) I find it a proof there must be some race. In fact if you check that RL_REDISPLAY modifies a lot of global variables being tangled by SIGINT-handler-called RL_FREE_LINE_STATE it is clear some locking is missing there. * Sure I am fine to keep the patch in the local branch. Best Regards, Jan