Re: [patch] Fix testsuite annotate-quit race (PR 544)

Jan Kratochvil
2008-03-19T09:31:47Z

On Wed, 19 Mar 2008 09:46:25 +0100, Nick Roberts wrote:
> > > > PR 544 des gdb.cp/annota2.exp and gdb.cp/annota3.exp sometimes FAIL with:
> > > > FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1)
> > ...
> > > Isn't this a bug in GDB, not a bug in the test?
> >
> > You are right it is probably better to fix it in readline.
>
> Annotations are being deprecated and the original bug report is nearly six
> years old. As as variation of the old adage, I would suggest that "Since
> no-one appears to mind it's broke, don't fix it". The danger of making a fix
> in readline, of course, is that you break annotations elsewhere, where it's
> more important.

* I still face testsuite results flutter making the day-to-day regressions
evaluations expensive. Most of the flutters are fixed in gdb-6.8 but still
some of them remain, this fix is for one of them.

* I do not care much if it FAILs or PASSes but it must not flutter.

* I found it is a known PR 544 only after I fixed it.

* I fixed it as it was a nuisance reported by the courtesy of Roland McGrath.

* As the SIGINT blocking in RL_REDISPLAY fixes the race (1 of 10 cases to 0 of
350 cases during my test) I find it a proof there must be some race.
In fact if you check that RL_REDISPLAY modifies a lot of global variables
being tangled by SIGINT-handler-called RL_FREE_LINE_STATE it is clear some
locking is missing there.

* Sure I am fine to keep the patch in the local branch.

Best Regards,
Jan