From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2743 invoked by alias); 17 Mar 2008 22:21:04 -0000 Received: (qmail 2735 invoked by uid 22791); 17 Mar 2008 22:21:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Mar 2008 22:20:44 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E1CFF983C0; Mon, 17 Mar 2008 22:20:42 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id BD6F998011; Mon, 17 Mar 2008 22:20:42 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JbNhB-0000vf-W8; Mon, 17 Mar 2008 18:20:42 -0400 Date: Mon, 17 Mar 2008 22:21:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Keep breakpoints always inserted. Message-ID: <20080317222041.GC1309@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200802281717.14766.vladimir@codesourcery.com> <20080310210844.GB14908@caradoc.them.org> <200803151312.15051.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803151312.15051.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00249.txt.bz2 On Sat, Mar 15, 2008 at 01:12:14PM +0300, Vladimir Prus wrote: > > This patch is OK, if you will add the missing pieces: a NEWS entry and > > documentation for the new command, and a testcase that enables > > always-inserted and verifies that it isn't a brick. > > I've added NEW and documentation. > > I'm still not sure how to test this adequately. This version is OK when Eli is happy with the documentation. For a testcase, I agree that we need to run the whole testsuite in this mode to get full coverage. But it's useful to have a single test that runs in this mode even if the rest of the testsuite doesn't, in case someone completely breaks it. That's why the gdb.server tests run for native targets that build gdbserver, even when the rest of the testsuite uses "run". Could you write a test that uses "set break always-inserted" and does something simple like running to a function and then continuing past it to another breakpoint? > + /* We're allowing a thread to run past a breakpoint it has > + hit, by single-stepping the thread with the breakpoint > + removed. In which case, we need to single-step only this > + thread, and keep others stopped, as they can miss this > + breakpoint if allowed to run. > + > + The current code actually removes all breakpoints when > + doing this, not just the one being stepped over, so if we > + let other threads run, we can actually miss any > + breakpoint, not just the one at PC. */ Extra spacing here? -- Daniel Jacobowitz CodeSourcery