From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1721 invoked by alias); 17 Mar 2008 19:10:58 -0000 Received: (qmail 1713 invoked by uid 22791); 17 Mar 2008 19:10:57 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Mar 2008 19:10:27 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2HJAOUT051046 for ; Mon, 17 Mar 2008 19:10:24 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2HJAOoo1843214 for ; Mon, 17 Mar 2008 20:10:24 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2HJANZH001730 for ; Mon, 17 Mar 2008 20:10:24 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m2HJANK2001727; Mon, 17 Mar 2008 20:10:23 +0100 Message-Id: <200803171910.m2HJANK2001727@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 17 Mar 2008 20:10:23 +0100 Subject: Re: [RFC] Use compilation unit's address size in dwarf2expr.c and dwarf2loc.c To: kevinb@redhat.com (Kevin Buettner), drow@false.org, jimb@read-bean.com Date: Mon, 17 Mar 2008 19:10:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080317110643.44441290@ironwood.lan> from "Kevin Buettner" at Mar 17, 2008 11:06:43 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00243.txt.bz2 Kevin Buettner wrote: > On Mon, 17 Mar 2008 14:35:03 +0100 (CET) > "Ulrich Weigand" wrote: > > > Here is my current patch, based on Jim Blandy's orignal patch and on > > Dan Jacobowitz' patch to fix DW_CFA_set_loc. With the exception of > > the one FIXME in decode_frame_entry_1, this patch fixes all issues > > related to dwarf address size handling that I'm aware of ... > > > > Tested on i386-linux, s390-linux, and s390x-linux. > > > > Does this look OK? > > I've tested your patch against the mips target upon which I was > seeing address size related problems. The results are comparable > to those obtained using the patch that I posted. > > So, as far as I'm concerned, your patch is okay to commit. Thanks for testing! Dan, Jim, if this is OK with you I'll go ahead and commit this version of the patch ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com