A Monday 17 March 2008 16:17:58, Daniel Jacobowitz wrote:
> On Mon, Mar 17, 2008 at 03:48:09PM +0000, Pedro Alves wrote:
> > +  if (args)
> > +    {
> > +      async_exec = strip_bg_char (&args);
> > +
> > +      /* If we get a request for running in the bg but the target
> > +         doesn't support it, error out. */
> > +      if (async_exec && !target_can_async_p ())
> > +	error (_("Asynchronous execution not supported on this target."));
> > +
> > +      /* If we don't get a request of running in the bg, then we need
> > +         to simulate synchronous (fg) execution.  */
> > +      if (!async_exec && target_can_async_p ())
> > +	{
> > +	  /* Simulate synchronous execution */
> > +	  async_disable_stdin ();
> > +	}
> > +    }
>
> This logic will work, since args should never be NULL anyway, but the
> call to async_disable_stdin is not dependent on args I think?
>

You're right, it's not.  Although this would only break if a
target has some sort of default pid to attach to.

> Otherwise OK.

Thanks!  This is what I checked in.

-- 
Pedro Alves