Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] Use compilation unit's address size in dwarf2expr.c and   dwarf2loc.c
Date: Mon, 17 Mar 2008 18:07:00 -0000	[thread overview]
Message-ID: <20080317110643.44441290@ironwood.lan> (raw)
In-Reply-To: <200803171335.m2HDZ3ad032124@d12av02.megacenter.de.ibm.com>

On Mon, 17 Mar 2008 14:35:03 +0100 (CET)
"Ulrich Weigand" <uweigand@de.ibm.com> wrote:

> Here is my current patch, based on Jim Blandy's orignal patch and on
> Dan Jacobowitz' patch to fix DW_CFA_set_loc.  With the exception of
> the one FIXME in decode_frame_entry_1, this patch fixes all issues
> related to dwarf address size handling that I'm aware of ...
> 
> Tested on i386-linux, s390-linux, and s390x-linux.
> 
> Does this look OK?

I've tested your patch against the mips target upon which I was
seeing address size related problems.  The results are comparable
to those obtained using the patch that I posted.

So, as far as I'm concerned, your patch is okay to commit.

Kevin


  reply	other threads:[~2008-03-17 18:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 22:15 Kevin Buettner
2008-03-15 19:36 ` Jim Blandy
2008-03-15 19:38   ` Jim Blandy
2008-03-16  1:39     ` Kevin Buettner
2008-03-17 13:35       ` Ulrich Weigand
2008-03-17 18:07         ` Kevin Buettner [this message]
2008-03-17 19:10           ` Ulrich Weigand
2008-03-17 19:15         ` Daniel Jacobowitz
2008-03-18  5:28           ` Jim Blandy
2008-03-18 19:42             ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317110643.44441290@ironwood.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox