From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27887 invoked by alias); 14 Mar 2008 18:58:49 -0000 Received: (qmail 27635 invoked by uid 22791); 14 Mar 2008 18:58:48 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 18:58:12 +0000 Received: (qmail 20922 invoked from network); 14 Mar 2008 18:58:09 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2008 18:58:09 -0000 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Async mode fixes. Date: Fri, 14 Mar 2008 18:58:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) References: <200803051027.29575.vladimir@codesourcery.com> <20080314182629.GD31663@caradoc.them.org> In-Reply-To: <20080314182629.GD31663@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803142158.18959.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00191.txt.bz2 On Friday 14 March 2008 21:26:29 Daniel Jacobowitz wrote: > On Wed, Mar 05, 2008 at 10:27:28AM +0300, Vladimir Prus wrote: > > + /* If any exception escaped to here, we better enable > > + stdin. Otherwise, any command that calls async_disable_stdin, > > + and the can throw, will leave stdin inoperable. */ > > and can throw? "and then throws", actually. > > > case INF_EXEC_COMPLETE: > > - /* Is there anything left to do for the command issued to > > - complete? */ > > + > > + /* This is the first thing to do -- so that continuations know that > > + the target is stopped. For example, command_line_handler_continuation > > + will run breakpoint commands, and if we thing that the target is > > + running, we'll refuse to execute most command. MI continuation > > + presently is target_executing to either print or not print *stopped. */ > > + target_executing = 0; > > "if we think", "most commands". "is" -> "uses" in the last line, right? right. > > > @@ -1005,10 +1006,28 @@ static void > > signal_command (char *signum_exp, int from_tty) > > Two spaces after periods in this function :-) > > > +/* Do any commands attached to breakpoint we stopped at. Only if we > > + are always running synchronously. Or if we have just executed a > > + command that doesn't start the target. */ > > Here too. > > > +static void > > +command_line_handler_continuation (struct continuation_arg *arg) > > +{ > > + extern int display_time; > > + extern int display_space; > > + > > + long time_at_cmd_start = arg->data.longint; > > + long space_at_cmd_start = arg->next->data.longint; > > + > > + bpstat_do_actions (&stop_bpstat); > > + /*do_cleanups (old_chain); *//*?????FIXME????? */ > > Clean up this, please. Oh, this is not mine, I've just moved command_line_handler_continuation to a different module. Anyway, some of later patches of mine removes that line as not necessary, and I might as well do it now. > > Other than that, this can go in now. Thanks. Between you and Nick > and Pedro I'm sure we'll have async mode working again soon. Thanks, checked in. - Volodya