From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14542 invoked by alias); 14 Mar 2008 19:18:52 -0000 Received: (qmail 14519 invoked by uid 22791); 14 Mar 2008 19:18:51 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 19:18:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 44A63983B5; Fri, 14 Mar 2008 19:18:22 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 20C91983AA; Fri, 14 Mar 2008 19:18:22 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JaFQ5-0000ul-6u; Fri, 14 Mar 2008 15:18:21 -0400 Date: Fri, 14 Mar 2008 19:18:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: attach& support, and attach "async + sync_execution" support. Message-ID: <20080314191821.GG31663@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200803140805.40116.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803140805.40116.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00193.txt.bz2 On Fri, Mar 14, 2008 at 08:05:39AM +0000, Pedro Alves wrote: > 2008-03-14 Pedro Alves > > * infcmd.c (attach_command_async_continuation): New. > (attach_command): Support background async execution, and async > execution in synchronous mode. Could you do some refactoring on this, please? It duplicates code from attach_command. When I fixed up step last year I moved the common code into its own function. Makes it much easier to see the differences between async and sync operation. And for instance it lets me see that you're calling deprecated_attach_hook twice in async mode :-) -- Daniel Jacobowitz CodeSourcery