From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15801 invoked by alias); 14 Mar 2008 18:26:52 -0000 Received: (qmail 15710 invoked by uid 22791); 14 Mar 2008 18:26:51 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 18:26:32 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A7D45983B5; Fri, 14 Mar 2008 18:26:30 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 7982A983AA; Fri, 14 Mar 2008 18:26:30 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JaEbt-00007C-NO; Fri, 14 Mar 2008 14:26:29 -0400 Date: Fri, 14 Mar 2008 18:26:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Async mode fixes. Message-ID: <20080314182629.GD31663@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200803051027.29575.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803051027.29575.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00189.txt.bz2 On Wed, Mar 05, 2008 at 10:27:28AM +0300, Vladimir Prus wrote: > + /* If any exception escaped to here, we better enable > + stdin. Otherwise, any command that calls async_disable_stdin, > + and the can throw, will leave stdin inoperable. */ and can throw? > case INF_EXEC_COMPLETE: > - /* Is there anything left to do for the command issued to > - complete? */ > + > + /* This is the first thing to do -- so that continuations know that > + the target is stopped. For example, command_line_handler_continuation > + will run breakpoint commands, and if we thing that the target is > + running, we'll refuse to execute most command. MI continuation > + presently is target_executing to either print or not print *stopped. */ > + target_executing = 0; "if we think", "most commands". "is" -> "uses" in the last line, right? > @@ -1005,10 +1006,28 @@ static void > signal_command (char *signum_exp, int from_tty) Two spaces after periods in this function :-) > +/* Do any commands attached to breakpoint we stopped at. Only if we > + are always running synchronously. Or if we have just executed a > + command that doesn't start the target. */ Here too. > +static void > +command_line_handler_continuation (struct continuation_arg *arg) > +{ > + extern int display_time; > + extern int display_space; > + > + long time_at_cmd_start = arg->data.longint; > + long space_at_cmd_start = arg->next->data.longint; > + > + bpstat_do_actions (&stop_bpstat); > + /*do_cleanups (old_chain); *//*?????FIXME????? */ Clean up this, please. Other than that, this can go in now. Thanks. Between you and Nick and Pedro I'm sure we'll have async mode working again soon. -- Daniel Jacobowitz CodeSourcery