From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24346 invoked by alias); 14 Mar 2008 15:33:33 -0000 Received: (qmail 23524 invoked by uid 22791); 14 Mar 2008 15:33:28 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 15:32:50 +0000 Received: (qmail 12560 invoked from network); 14 Mar 2008 15:32:48 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2008 15:32:48 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: enable a couple of useful cli commands in async mode. Date: Fri, 14 Mar 2008 15:33:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) References: <200803140759.55397.pedro@codesourcery.com> <20080314143540.GA18511@caradoc.them.org> In-Reply-To: <20080314143540.GA18511@caradoc.them.org> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_qqp2HkKBzfXojma" Message-Id: <200803141532.58777.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00177.txt.bz2 --Boundary-00=_qqp2HkKBzfXojma Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1711 A Friday 14 March 2008 14:35:40, Daniel Jacobowitz wrote: > On Fri, Mar 14, 2008 at 07:59:55AM +0000, Pedro Alves wrote: > > This is needed to test/develop async with CLI. The info info command is > > very useful to debug gdb itself, and the interrupt command is needed to > > be able to SIGINT the target. Without it, the user is trapped in the > > hole of wanting to quit, but gdb complaining "I can't do that Dave" while > > the target is running. "stop" is there already, so I added break too, > > although it doesn't work yet. > > > > CLI command filtering this way is a gross hack that needs cleaning > > up anyway. Since noone is using this currently, I went ahead and > > installed as obvious. > > I'm confused by your choices. "stop" is not the command you think it > is. There's a "stop_command" in breakpoint.c but that's the > DBX-compatibility version of "break". The command "stop" doesn't > do anything; it's only there for hook-stop. > I see. At first I thought it should do what interrupt does, but then I saw the dbx compatibility version, and just assumed it was it. (it was calling nothing, and I assumed it was because I didn't have dbx mode on ...) > Also, how can we enable "info"? That will let you type "info regs" > while the target is running; does something produce a useful error > further down? > It doesn't let you type info registers, because c->name is "registers" in that case. It just let's you type "info". That is useful for the hook that switches to the top gdb when debugging gdb in gdb. > "interrupt" makes sense. In fact I think this is what whoever added > "stop" actually meant to add. Yeah. Want me to remove stop and breakpoint? -- Pedro Alves --Boundary-00=_qqp2HkKBzfXojma Content-Type: text/x-diff; charset="iso-8859-1"; name="remove_break_stop.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove_break_stop.diff" Content-length: 799 2008-03-14 Pedro Alves * top.c (execute_command): Disable break and stop commands in async mode. --- gdb/top.c | 2 -- 1 file changed, 2 deletions(-) Index: src/gdb/top.c =================================================================== --- src.orig/gdb/top.c 2008-03-14 15:30:28.000000000 +0000 +++ src/gdb/top.c 2008-03-14 15:30:38.000000000 +0000 @@ -405,8 +405,6 @@ execute_command (char *p, int from_tty) if (strcmp (c->name, "help") != 0 && strcmp (c->name, "pwd") != 0 && strcmp (c->name, "show") != 0 - && strcmp (c->name, "stop") != 0 - && strcmp (c->name, "break") != 0 && strcmp (c->name, "info") != 0 && strcmp (c->name, "interrupt") != 0) error (_("Cannot execute this command while the target is running.")); --Boundary-00=_qqp2HkKBzfXojma--