From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20009 invoked by alias); 12 Mar 2008 16:03:28 -0000 Received: (qmail 19998 invoked by uid 22791); 12 Mar 2008 16:03:28 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Mar 2008 16:03:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AFAF32AA221; Wed, 12 Mar 2008 12:03:08 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dh-ZzK4TLzu5; Wed, 12 Mar 2008 12:03:08 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6F9BC2AA4B4; Wed, 12 Mar 2008 12:03:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2612FE7ACB; Wed, 12 Mar 2008 09:03:06 -0700 (PDT) Date: Wed, 12 Mar 2008 16:03:00 -0000 From: Joel Brobecker To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Don't paginate "new thread" events Message-ID: <20080312160306.GB3738@adacore.com> References: <200803120149.11929.pedro@codesourcery.com> <20080312030129.GA3738@adacore.com> <20080312031329.GA12967@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080312031329.GA12967@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00127.txt.bz2 > The one most frequently encountered, in linux-thread-db.c, > was already unfiltered for this very reason. Ooops, right! A grep instead of a visual read of Vladimir's patch shows very clearly that there were already 3 locations where we used to use the printf unfiltered. So Pedro's patch is definitely OK. 2008-03-12 Pedro Alves * thread.c (add_thread): Use printf_unfiltered to print. This should go to the branch as well. --- gdb/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/thread.c =================================================================== --- src.orig/gdb/thread.c 2008-03-12 01:36:24.000000000 +0000 +++ src/gdb/thread.c 2008-03-12 01:36:42.000000000 +0000 @@ -136,7 +136,7 @@ add_thread (ptid_t ptid) struct thread_info *result = add_thread_silent (ptid); if (print_thread_events) - printf_filtered (_("[New %s]\n"), target_pid_to_str (ptid)); + printf_unfiltered (_("[New %s]\n"), target_pid_to_str (ptid)); return result; } -- Joel