From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8647 invoked by alias); 12 Mar 2008 03:01:53 -0000 Received: (qmail 8639 invoked by uid 22791); 12 Mar 2008 03:01:52 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Mar 2008 03:01:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 52A112AA3CA; Tue, 11 Mar 2008 23:01:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GxrChtMKQbuN; Tue, 11 Mar 2008 23:01:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D4B402AA3C7; Tue, 11 Mar 2008 23:01:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 66B6FE7ACB; Tue, 11 Mar 2008 20:01:29 -0700 (PDT) Date: Wed, 12 Mar 2008 03:01:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Don't paginate "new thread" events Message-ID: <20080312030129.GA3738@adacore.com> References: <200803120149.11929.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803120149.11929.pedro@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00119.txt.bz2 > New thread events printing ("New Thread 0x40077950 (LWP 13229)]") was > recently centralised in add_thread. Unfortunatelly it brought with > it a behaviour change. Before, we wouldn't paginate when these > events filled the terminal screen, and now we do. Actually, I think it's a little more complicated than that. I had a second look at the patch, and the routines that were used to print the event notifications were either "printf_filtered" or "ui_out_text" (which in CLI mode results in a printf_filtered). I think the centralization just caused more messages to printed compared to before, but that's just a guess. Perhaps, you could check an older debugger (before the notification was centralized inside "add_thread", for instance 6.7.1) with a much smaller terminal height, and see if you get the same kind of issues... > This is quite bad, as gdb now waits for use input to proceed. Also, > since add_thread doesn't target_terminal_ours, gdb just stops due to > SIGTTOU when the pagination kicks in ("want to continue y or n" > prompt). User now has to fg to restore it... However, I tend to agree that having these notifications be paginated can be annoying. I support the change below, but I'd like to have other's opinion. Based on the analysis above, your patch would be introducing a change of behavior, so a consensus on its usefulness would be nice... -- Joel