From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15954 invoked by alias); 10 Mar 2008 20:57:47 -0000 Received: (qmail 15938 invoked by uid 22791); 10 Mar 2008 20:57:46 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 20:57:28 +0000 Received: (qmail 22884 invoked from network); 10 Mar 2008 20:57:26 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Mar 2008 20:57:26 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: [RFA] Try2: Ignore breakpoints when reading memory. Date: Mon, 10 Mar 2008 20:57:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200802241750.41264.vladimir@codesourcery.com> <20080310204242.GA14908@caradoc.them.org> In-Reply-To: <20080310204242.GA14908@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803102357.23694.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00108.txt.bz2 On Monday 10 March 2008 23:42:42 Daniel Jacobowitz wrote: > On Sun, Feb 24, 2008 at 05:50:39PM +0300, Vladimir Prus wrote: > > > > This a second attempt at making gdb always ignore > > any memory breakpoints that are inserted and show the original > > memory content. This patch is the immediate prerequisite for the > > patch that makes breakpoints always inserted. > > > > Unlike the previous patch, there's a mechanism to: > > 1. Control the new behaviour from command line. > > Do you think we need the option is useful? I think we'll want one for > leave-breakpoints-inserted mode, which is a bigger change, but this > patch should only affect GDB internals. I've added the option as it might be helpful to see real memory content, say, when diagnosing problems with gdb/stub itself. > > > +static void > > +restore_show_memory_breakpoints (void *arg) > > +{ > > + show_memory_breakpoints = (int)arg; > > +} > > This will fail with -Werror on a 64-bit host. Ah, right. > That leaves the attached patch. Tested on x86_64-linux, no > regressions. How's it look? I deleted read_memory_nobpt > entirely. I think it's good. - Volodya