From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54450-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15388 invoked by alias); 10 Mar 2008 12:23:46 -0000
Received: (qmail 15152 invoked by uid 22791); 10 Mar 2008 12:23:41 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 12:23:23 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m2ACN9he027988; 	Mon, 10 Mar 2008 13:23:09 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m2ACN951020082; 	Mon, 10 Mar 2008 13:23:09 +0100 (CET)
Date: Mon, 10 Mar 2008 12:23:00 -0000
Message-Id: <200803101223.m2ACN951020082@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: uweigand@de.ibm.com
CC: deuling@de.ibm.com, gdb-patches@sourceware.org, drow@false.org
In-reply-to: <200803101213.m2ACD3aP028558@d12av02.megacenter.de.ibm.com> 	(uweigand@de.ibm.com)
Subject: Re: [rfc] Replace x86 register macros
References:  <200803101213.m2ACD3aP028558@d12av02.megacenter.de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00092.txt.bz2

> Date: Mon, 10 Mar 2008 13:13:03 +0100 (CET)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> 
> Markus Deuling wrote:
> 
> > Thanks for review, I reworked the patch now. Ok to commit?
> 
> > +#define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM(tdep) + 8)
> > +#define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 1)
> > +#define I387_FTAG_REGNUM(tdep)  (I387_FCTRL_REGNUM(tdep)+ 2)
> > +#define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 3)
> > +#define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 4)
> > +#define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 5)
> > +#define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 6)
> > +#define I387_FOP_REGNUM(tdep)   (I387_FCTRL_REGNUM(tdep)+ 7)
> > +#define I387_XMM0_REGNUM(tdep)  (I387_ST0_REGNUM(tdep)+ 16)
> > +#define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM(tdep) \
> > ++ I387_NUM_XMM_REGS(tdep))
> 
> I guess I should have been more specific about the formatting;
> this is unfortunately still not quite right:  On the right-hand
> sides, you should use normal whitespace rules, i.e. spaces before
> the '(' and '+'.  Also, the last line should be properly 
> indented, somthing like:
> 
> #define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM (tdep) \
> 				 + I387_NUM_XMM_REGS (tdep))

Or better yet, something like:

#define I387_MXCSR_REGNUM(tdep) \
  (I387_XMM0_REGNUM (tdep) + I387_NUM_XMM_REGS (tdep))