From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12427 invoked by alias); 10 Mar 2008 12:13:49 -0000 Received: (qmail 12391 invoked by uid 22791); 10 Mar 2008 12:13:40 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 12:13:07 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2ACD4GV372504 for ; Mon, 10 Mar 2008 12:13:04 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2ACD45t2031674 for ; Mon, 10 Mar 2008 13:13:04 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2ACD3h6028563 for ; Mon, 10 Mar 2008 13:13:03 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m2ACD3aP028558; Mon, 10 Mar 2008 13:13:03 +0100 Message-Id: <200803101213.m2ACD3aP028558@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 10 Mar 2008 13:13:03 +0100 Subject: Re: [rfc] Replace x86 register macros To: deuling@de.ibm.com (Markus Deuling) Date: Mon, 10 Mar 2008 12:13:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz) In-Reply-To: <47D4DBE1.3000703@de.ibm.com> from "Markus Deuling" at Mar 10, 2008 07:57:37 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00091.txt.bz2 Markus Deuling wrote: > Thanks for review, I reworked the patch now. Ok to commit? > +#define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM(tdep) + 8) > +#define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 1) > +#define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 2) > +#define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 3) > +#define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 4) > +#define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 5) > +#define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 6) > +#define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 7) > +#define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM(tdep)+ 16) > +#define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM(tdep) \ > ++ I387_NUM_XMM_REGS(tdep)) I guess I should have been more specific about the formatting; this is unfortunately still not quite right: On the right-hand sides, you should use normal whitespace rules, i.e. spaces before the '(' and '+'. Also, the last line should be properly indented, somthing like: #define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM (tdep) \ + I387_NUM_XMM_REGS (tdep)) With these formatting changes, the patch is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com