From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20266 invoked by alias); 4 Mar 2008 00:32:06 -0000 Received: (qmail 20255 invoked by uid 22791); 4 Mar 2008 00:32:05 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Mar 2008 00:31:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m240VfnP494624 for ; Tue, 4 Mar 2008 00:31:41 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m240VfAN1433802 for ; Tue, 4 Mar 2008 01:31:41 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m240VeCZ002776 for ; Tue, 4 Mar 2008 00:31:40 GMT Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m240VedE002773; Tue, 4 Mar 2008 00:31:40 GMT Message-Id: <200803040031.m240VedE002773@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 4 Mar 2008 01:31:40 +0100 Subject: Re: [rfc] Replace x86 register macros To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 04 Mar 2008 00:32:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz) In-Reply-To: <47BC58A9.2030802@de.ibm.com> from "Markus Deuling" at Feb 20, 2008 05:43:21 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00027.txt.bz2 Markus Deuling wrote: > thanks both for your input. I reworked the patch now. Tested on x86 without regressions > Maybe someone can run a test on amd64 as I don't have such a machine? I've tested this on amd64-linux with no regressions. > +#define I387_ST0_REGNUM(tdep) (tdep->st0_regnum) > +#define I387_NUM_XMM_REGS(tdep) (tdep->num_xmm_regs) > +#define I387_MM0_REGNUM(tdep) (tdep->mm0_regnum) You need to put parentheses around "tdep" to protect against macro evaluation issues ... > +#define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM(tdep) + 8) > +#define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 1) > +#define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 2) > +#define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 3) > +#define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 4) > +#define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 5) > +#define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 6) > +#define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 7) > +#define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM(tdep)+ 16) > +#define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM(tdep) \ > ++ I387_NUM_XMM_REGS(tdep)) Formatting (whitespace and indentation) is a bit odd here. Also, you've forgotten to adapt a couple of uses of the I387_ macros in win32-nat.c. Otherwise, this looks fine to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com