From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30143 invoked by alias); 3 Mar 2008 20:39:22 -0000 Received: (qmail 30134 invoked by uid 22791); 3 Mar 2008 20:39:22 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Mar 2008 20:39:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 18F2D98119; Mon, 3 Mar 2008 20:39:00 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 028E39802C; Mon, 3 Mar 2008 20:38:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JWHR4-0005oH-Js; Mon, 03 Mar 2008 15:38:58 -0500 Date: Mon, 03 Mar 2008 20:39:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Mark Kettenis , deuling@de.ibm.com, gdb-patches@sourceware.org, uweigand@de.ibm.com Subject: Re: [patch] Add proper error message instead of gdb_assert Message-ID: <20080303203858.GA22316@caradoc.them.org> Mail-Followup-To: Michael Snyder , Mark Kettenis , deuling@de.ibm.com, gdb-patches@sourceware.org, uweigand@de.ibm.com References: <47CC5332.3020700@de.ibm.com> <200803031955.m23Jt7cj019540@brahms.sibelius.xs4all.nl> <1204576131.19253.582.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1204576131.19253.582.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00022.txt.bz2 On Mon, Mar 03, 2008 at 12:28:51PM -0800, Michael Snyder wrote: > On Mon, 2008-03-03 at 20:55 +0100, Mark Kettenis wrote: > > > > > Sorry, but I don't see why your error message is "proper". The > > gdb_assert() should never fail; the fact that it does means that you > > have a bug elsewhere in gdb. > > Isn't that what the "internal error" call is for? gdb_assert calls internal_error anyway. -- Daniel Jacobowitz CodeSourcery