From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28887 invoked by alias); 3 Mar 2008 20:00:28 -0000 Received: (qmail 28876 invoked by uid 22791); 3 Mar 2008 20:00:27 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Mar 2008 20:00:03 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m23K001c206750 for ; Mon, 3 Mar 2008 20:00:00 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m23K00Mk1417262 for ; Mon, 3 Mar 2008 21:00:00 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m23K00QH027861 for ; Mon, 3 Mar 2008 20:00:00 GMT Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m23K00SA027858; Mon, 3 Mar 2008 20:00:00 GMT Message-Id: <200803032000.m23K00SA027858@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 3 Mar 2008 21:00:00 +0100 Subject: Re: [patch] Add proper error message instead of gdb_assert To: deuling@de.ibm.com (Markus Deuling) Date: Mon, 03 Mar 2008 20:00:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <47CC5332.3020700@de.ibm.com> from "Markus Deuling" at Mar 03, 2008 08:36:18 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00015.txt.bz2 Markus Deuling wrote: > when trying to put > 1 values into an array (fortran subrange) which > comes from a register, register_size is called with regnum == -1. You need to fix the caller to not do this, then. > This patch replaces that gdb_assert by a proper error message before > exiting: An "internal error" is neither more nor less "proper" than a failed assertion. Both say "there's a bug in GDB", and neither should be triggerable by normal user interaction. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com